[Feature] Build and run C++ Python tests #218
Open
+61
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: Add support for multi-arch |
|
nice |
Ahajha
reviewed
Feb 25, 2025
.github/workflows/unit_test.yaml
Outdated
|
|
||
| - name: Run C++ tests | ||
| run: | | ||
| cd build && ctest && cd .. |
There was a problem hiding this comment.
Should be able to do a ctest --test-dir build
zbowling
approved these changes
Mar 6, 2025
Ubospica
reviewed
Mar 12, 2025
Comment on lines
+49
to
+55
| - name: Run Python tests without HF_TOKEN | ||
| env: | ||
| HF_TOKEN: ${{ secrets.HF_TOKEN }} | ||
| if: env.HF_TOKEN == '' | ||
| run: | | ||
| pip install pytest | ||
| pytest -m "not hf_token_required" |
There was a problem hiding this comment.
Is this part necessary? I think Run Python tests should have covered all tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ci (#214) to build xgrammar from source code and run all C++ tests and Python tests (except for those HF_TOKEN needed tests).